Skip to content

TRUNK-4860: Assert validation error code for blank gender in PatientV… #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
emphor11 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

TRUNK-4860: Assert validation error code for blank gender in PatientV… #5720

emphor11 wants to merge 2 commits into from
+9 −0

Conversation

@emphor11
Copy link

@emphor11 emphor11 commented Jan 29, 2026

TRUNK-4860: Update PatientValidator test validation messages

Description of what I changed

Updated validation behavior and ensured correct validation messages in PatientValidator.
Verified and updated PatientValidatorTest so that all validation scenarios behave as expected.
All tests pass successfully after the changes.

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-4860

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

  • I have added tests to cover my changes (or verified existing tests where applicable).

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

@emphor11
Copy link
Author

emphor11 commented Jan 29, 2026

@dkayiwa
I’ve submitted this PR to address TRUNK-4860.
Could you please take a look when you get a chance?
Thanks!

mherman22
mherman22 reviewed Jan 29, 2026
View reviewed changes
Copy link
Member

@mherman22 mherman22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the following test methods also need your attention in this very test class:

  • validate_shouldFailValidationIfAPreferredPatientIdentifierIsNotChose
  • validate_shouldFailValidationIfFieldLengthsAreNotCorrect

@emphor11
Copy link
Author

emphor11 commented Jan 29, 2026

Thanks for the review @mherman22
Good catch — I’ll update those two test methods as well to assert the correct validation messages and push an update shortly.

@emphor11
TRUNK-4860: Assert validation error code for blank gender in PatientV…
1c0c213 
…alidatorTest

TRUNK-4860: Assert validation error codes in PatientValidatorTest
@emphor11 emphor11 force-pushed the TRUNK-4860-validator-test-messages branch from babf59b to 1c0c213 Compare January 29, 2026 08:20
@emphor11
Copy link
Author

emphor11 commented Jan 29, 2026 •
edited
Loading

@mherman22 @dkayiwa
I’ve pushed the updated changes addressing the feedback.
All tests are passing locally now. Thanks!

@emphor11
Copy link
Author

emphor11 commented Jan 30, 2026

@dkayiwa @mherman22
If there anything else on which you want my attention regarding this PR you can let me know.
Thanks

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@emphor11
Copy link
Author

emphor11 commented Feb 3, 2026

Hi @dkayiwa @mherman22 ,

It looks like some CI checks were cancelled after the recent branch update.
All tests were passing locally and previously on CI.

Could you please re-run the cancelled checks or let me know if you’d like me to update anything?

Thanks!

@emphor11 emphor11 requested a review from mherman22 February 3, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mherman22 mherman22 Awaiting requested review from mherman22

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emphor11 @mherman22